fix(test): typedoc signature test issues #2280
Merged
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2280 +/- ##
=======================================
Coverage 99.59% 99.60%
=======================================
Files 2641 2641
Lines 244831 244831
Branches 1082 1082
=======================================
+ Hits 243846 243855 +9
+ Misses 958 949 -9
Partials 27 27 |
ST-DDT
force-pushed
the
fix/typedoc-test-issues
branch
from
b82fc49 to
c414854
Compare
The folder should be deleted immediately after the test runs, but on macOS it exists long enough for typedoc to pick it up and the complain about the files being deleted.
ST-DDT
force-pushed
the
fix/typedoc-test-issues
branch
from
c414854 to
3ba2606
Compare
Shinigami92
approved these changes
Jul 29, 2023
matthewmayer
approved these changes
Jul 29, 2023
ejcheng
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PRs tries to fix the frequent issues with macOS and our signature tests.
Unfortunately, I don't have a way to test it.
I explicitly ignore the temp folder in the tsconfig to avoid issues with temp files that are detected by either concurrently running tests with typedoc or files being removed async although the should be removed sync and thus being still there when typedoc runs again on the project.